Skip to content

usb: make device-next default and move legacy sample code to legacy directory #87269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Aug 6, 2025
Merged

usb: make device-next default and move legacy sample code to legacy directory #87269

merged 28 commits into from
Aug 6, 2025

Conversation

jfischer-no
Copy link
Contributor

Make USB device-next samples default and move legacy code to legacy directory.

@jfischer-no jfischer-no added area: USB Universal Serial Bus area: Samples Samples DNM This PR should not be merged (Do Not Merge) labels Mar 18, 2025
@jfischer-no jfischer-no added this to the v4.2.0 milestone Mar 18, 2025
@carlescufi carlescufi mentioned this pull request Mar 19, 2025
Open
57 tasks
tmon-nordic
tmon-nordic requested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@tmon-nordic tmon-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some CDC ACM twister failures, some where both USB stacks seem to be active simultaneously and some where there doesn't seem to be CDC ACM devicetree instance.

henrikbrixandersen
henrikbrixandersen requested changes Mar 24, 2025
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much same comment as last time this was proposed (see #80985 (comment)):

As already stated in an earlier comment on this PR (#80985 (review)) I do not think "device_next" is ready becoming the default USB device stack in Zephyr v4.1.

There's the issue with lack of "vendor" testing (tested it on a random selection of development boards, three of the new USB device drivers failed to enumerate on MS Windows), the lack of support for a number of platforms (I know some people find it acceptable to "leave these behind"), the list of open bug reports - and especially the vastly increased RAM/ROM footprint as reported in #83309. These are all mentioned in #42066 but not yet handled with 9 days until v4.1 feature freeze.

@jfischer-no jfischer-no force-pushed the pr-samples-usb-use-device_next branch from 53c9919 to 15be1f2 Compare March 26, 2025 12:08
@carlescufi
Copy link
Member

the lack of support for a number of platforms (I know some people find it acceptable to "leave these behind"),

We agreed those would not be a factor I believe, after I sent an informative email to devel@

the list of open bug reports

Which are those? I am not familiar with these.

and especially the vastly increased RAM/ROM footprint as reported in #83309.

Agreed, this needs to be addressed.

@henrikbrixandersen
Copy link
Member

Which are those? I am not familiar with these.

I meant the open issues reported against the device_next stack here on GitHub. Personally, I think the following would be relevant to look at before making this the default stack. Some of these have gone months without any maintainer feedback:

@carlescufi
Copy link
Member

I meant the open issues reported against the device_next stack here on GitHub. Personally, I think the following would be relevant to look at before making this the default stack. Some of these have gone months without any maintainer feedback:

I agree with you. @jfischer-no and @tmon-nordic could you please go over these and see what can be fixed?

@jfischer-no
Copy link
Contributor Author

I meant the open issues reported against the device_next stack here on GitHub. Personally, I think the following would be relevant to look at before making this the default stack. Some of these have gone months without any maintainer feedback:

I agree with you. @jfischer-no and @tmon-nordic could you please go over these and see what can be fixed?

I am on
#74058
#87732 (is not a bug)
#86718 (is not a bug)

nandojve
nandojve previously approved these changes Jul 31, 2025
View reviewed changes
@fabiobaltieri
Copy link
Member

@jfischer-no looks like this is good to go, can you get the module PR in and manifest updated?

@carlescufi
Copy link
Member

@jfischer-no looks like this is good to go, can you get the module PR in and manifest updated?

Upstream PR is here: mcu-tools/mcuboot#2413
@nordicjm @nvlsianpu we would need that merged and synced in Zephyr to merge this PR

@nordicjm @jfischer-no
west.yml: MCUboot synchronization from upstream
8644103 
Update Zephyr fork of MCUboot to revision:
  4e108f702b5322fb59344ae4976e3d73c973ef12

Brings following Zephyr relevant fixes:

  - 4e108f70 boot: zephyr: adjust sample.yaml to pass USB
    deprecation process
  - 29690581 boot: zephyr: boards: update name of nrf54h20dk
  - cb92ebeb boot: zephyr: boards: nrf52: Fix minimal config
  - 1d7fe64b boot: zephyr: boards: nrf54l15dk: Remove invalid
    Kconfigs
  - c033b71b boot: zephyr: Remove reference to old Kconfigs
  - 268968f8 zephyr: Add support for AES256
  - a5c48f3c imgtool: Allow for AES256 encryption
  - fc8477e5 boot: bootutil: image_validate: Add error on security
    counter fail
  - d5f84b49 zephyr: Add support for slot selection boot hook
  - 7c4ec9ab loader: Add boot hook for slot selection
  - 94d85f91 imgtool: Fix x25519 TLV HMAC tag
  - 32db7886 bootutil: Fix X25519 HMAC-SHA512
  - 2bc36d0f bootutil: Expose hardware security counter
  - b475adf7 zephyr: Add CONFIG_BOOT_BYPASS_KEY_MATCH
  - 6d943d68 bootutil: Support for MCUBOOT_BYPASS_KEY_MATCH
  - e2e372f2 boot: Add config for dongle bare variant
  - dce784a2 loader: Allow to specify slot number in version
  - 5ee96f5b zephyr: Enable building ECDSA PSA variant

Signed-off-by: Jamie McCrae <[email protected]>
@jfischer-no jfischer-no force-pushed the pr-samples-usb-use-device_next branch from b8ead61 to 8644103 Compare August 6, 2025 11:23
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Aug 6, 2025
@carlescufi
Copy link
Member

@fabiobaltieri @henrikbrixandersen @nandojve @jukkar @tmon-nordic
Last push is just bringing the MCUboot commit into Zephyr's fork.

@carlescufi carlescufi removed this from Release Plan Aug 6, 2025
@cfriedt cfriedt merged commit 9759ca6 into zephyrproject-rtos:main Aug 6, 2025
41 of 43 checks passed
@hakehuang
Copy link
Contributor

this breaks sample.net.sockets.http.server on many NXP platforms like mimxrt1170_evk

@hakehuang hakehuang mentioned this pull request Aug 7, 2025
Closed
1 task
@khoa-nguyen-18 khoa-nguyen-18 mentioned this pull request Aug 8, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@jhedberg jhedberg jhedberg approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@carlescufi carlescufi carlescufi approved these changes

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@hermabe hermabe Awaiting requested review from hermabe

@mrodgers-witekio mrodgers-witekio Awaiting requested review from mrodgers-witekio

@nashif nashif Awaiting requested review from nashif

@pdgendt pdgendt Awaiting requested review from pdgendt

@rlubos rlubos Awaiting requested review from rlubos

@ssharks ssharks Awaiting requested review from ssharks

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@kartben kartben Awaiting requested review from kartben

@jukkar jukkar Awaiting requested review from jukkar

@nandojve nandojve Awaiting requested review from nandojve

@tmon-nordic tmon-nordic Awaiting requested review from tmon-nordic

Assignees

@jfischer-no jfischer-no

Labels
area: Samples Samples area: USB Universal Serial Bus manifest manifest-mcuboot
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.